⚡ Bolt: [performance improvement] Short-circuit evaluation in CacheoutViewModel#348
⚡ Bolt: [performance improvement] Short-circuit evaluation in CacheoutViewModel#348acebytes wants to merge 1 commit into
Conversation
Replaced `!selectedResults.isEmpty` with `scanResults.contains(where: \.isSelected)` and updated `selectedSize` to use `.lazy.filter(\.isSelected)`. `hasSelection` and `selectedSize` are computed properties accessed frequently by SwiftUI. Previously, they implicitly accessed `selectedResults` which performed an eager `.filter`, allocating a new array every time. `contains(where:)` short-circuits as soon as a match is found and completely avoids array allocation, significantly reducing memory churn. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What: Replaced!selectedResults.isEmptywithscanResults.contains(where: \.isSelected)and updatedselectedSizeto use.lazy.filter(\.isSelected).🎯 Why:hasSelectionandselectedSizeare computed properties accessed frequently by SwiftUI. Previously, they implicitly accessedselectedResultswhich performed an eager.filter, allocating a new array every time.contains(where:)short-circuits as soon as a match is found and completely avoids array allocation, significantly reducing memory churn.📊 Impact: O(N) -> O(1) best case forhasSelection. Prevents unnecessary array allocations during SwiftUI render cycles.🔬 Measurement: Profile memory allocations during UI updates (e.g., ticking checkboxes). Memory churn fromScanResultarray allocations will be eliminated.PR created automatically by Jules for task 9467996035423327112 started by @acebytes