Skip to content

⚡ Bolt: Optimize computed properties in CacheoutViewModel#319

Closed
acebytes wants to merge 1 commit into
mainfrom
bolt-optimize-viewmodel-computed-properties-7015341090453744809
Closed

⚡ Bolt: Optimize computed properties in CacheoutViewModel#319
acebytes wants to merge 1 commit into
mainfrom
bolt-optimize-viewmodel-computed-properties-7015341090453744809

Conversation

@acebytes

Copy link
Copy Markdown
Contributor

💡 What: Replaced .isEmpty checks on filtered arrays with .contains(where:) in hasSelection, and chained .lazy.filter before .reduce in selectedSize.
🎯 Why: To prevent intermediate array allocations and short-circuit evaluation, avoiding O(N) memory churn in heavily-accessed SwiftUI computed properties.
📊 Impact: Reduces memory overhead and avoids full array traversal when checking if any item is selected.
🔬 Measurement: Verified the application compiles and the modified properties still return correct values.


PR created automatically by Jules for task 7015341090453744809 started by @acebytes

Replaced `.isEmpty` checks on filtered arrays with `.contains(where:)` in `hasSelection`, and chained `.lazy.filter` before `.reduce` in `selectedSize`. This prevents intermediate array allocations and short-circuits evaluation, avoiding O(N) memory churn in heavily-accessed SwiftUI computed properties.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes

Copy link
Copy Markdown
Contributor Author

Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in CacheoutViewModel.swift and MenuBarView.swift / CleanConfirmation.swift. Consolidating on #393 as the canonical (most recent iteration).

@acebytes acebytes closed this Jun 16, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in CacheoutViewModel.swift and MenuBarView.swift / CleanConfirmation.swift. Consolidating on #393 as the canonical (most recent iteration).

Understood. Acknowledging that this work is a duplicate and stopping work on this task.

@acebytes acebytes deleted the bolt-optimize-viewmodel-computed-properties-7015341090453744809 branch June 16, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant