Skip to content

⚡ Bolt: Prevent intermediate array allocations with lazy filter #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acebytes wants to merge 1 commit into from
Closed

⚡ Bolt: Prevent intermediate array allocations with lazy filter #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Cacheout/ViewModels/CacheoutViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ class CacheoutViewModel: ObservableObject {
}

var selectedSize: Int64 {
selectedResults.reduce(0) { $0 + $1.sizeBytes }
// ⚡ Bolt: Optimized by using .lazy.filter before .reduce to prevent intermediate array allocation
// Expected Impact: Reduces memory churn and array allocation overhead on UI updates
scanResults.lazy.filter(\.isSelected).reduce(0) { $0 + $1.sizeBytes }
}

var formattedSelectedSize: String {
Expand Down
7 changes: 6 additions & 1 deletion Sources/Cacheout/Views/MenuBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ struct MenuBarView: View {
Spacer()
statPill(
label: "Categories",
value: "\(viewModel.scanResults.filter { !$0.isEmpty }.count)",
// ⚡ Bolt: Optimized by using .lazy.filter.count to prevent intermediate array allocation
// Expected Impact: Eliminates eager O(N) array allocation when computing the category count
value: "\(viewModel.scanResults.lazy.filter { !$0.isEmpty }.count)",
color: .blue
)
}
Expand All @@ -177,7 +179,10 @@ struct MenuBarView: View {
// MARK: - Top Categories

private var topCategories: some View {
// ⚡ Bolt: Optimized by using .lazy.filter before .sorted to prevent intermediate array allocation
// Expected Impact: Reduces memory footprint by avoiding an intermediate filtered array before sorting
let top = viewModel.scanResults
.lazy
.filter { !$0.isEmpty }
.sorted { $0.sizeBytes > $1.sizeBytes }
.prefix(5)
Expand Down
Loading