⚡ Bolt: Optimize computed properties to avoid intermediate array allocations#306
⚡ Bolt: Optimize computed properties to avoid intermediate array allocations#306acebytes wants to merge 1 commit into
Conversation
…cations - Use `.lazy.filter` before `.reduce` in `selectedSize` to prevent O(N) intermediate array allocations. - Replace `!selectedResults.isEmpty` with `scanResults.contains(where:)` in `hasSelection` to short-circuit evaluation. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in |
Understood. Acknowledging that this work is a duplicate and stopping work on this task. |
acebytes
deleted the
bolt-optimize-computed-properties-3461001768574288850
branch
1 participant
💡 What: Replaced an eager
filterfollowed byreducewith a.lazy.filter.reducechain, and replaced!selectedResults.isEmptywithscanResults.contains(where:)inCacheoutViewModel. Added inline explanatory comments.🎯 Why: In SwiftUI, computed properties on
@Publishedview models can be evaluated frequently. Using an eager.filterarray to check.isEmptyorreduceallocates intermediate arrays on every access, causing unnecessary memory churn.📊 Impact: Eliminates O(N) array allocations for
selectedSizeandhasSelection, and turnshasSelectioninto an O(1) short-circuit operation when an item is selected.🔬 Measurement: Profile with Instruments (Allocations track) while toggling selection to observe eliminated array allocations.
PR created automatically by Jules for task 3461001768574288850 started by @acebytes