fix host key verification always passing due to hash() returning a stale digest instead of the updated buffer, add regression test - #84
Merged
Conversation
…ale digest instead of the updated buffer, add regression test
miraz12
changed the title
…unction str except block, updating expected hash result for get_r_pathed
…ale digest instead of the updated buffer, add regression test
miraz12
force-pushed
the
helper_hash_fix
branch
from
September 7, 2026 06:33
063c1cf to
b39d8de
Compare
Contributor
Author
|
Rebased on root, tests pass locally again :) |
…ead-only server testing for put, rename and remove. Refactor for a few more tests that could leave lingering artifacts on failure, switching tempfile_containing to a fixture to standarize usage across the test suite. Switching to OSError catch for hash function str handling. Version bump.
…ts in test_put file and moved a line that should have been in part of the test above.
… only defined in the str section yet was being called for file object branches. Use strings for content as tempfile_containing expects and encode for only for hashlib calls.
byteskeptical
approved these changes
Sep 8, 2026
byteskeptical
left a comment
byteskeptical
left a comment
Owner
There was a problem hiding this comment.
Overall looks good, ended up adding some additional testing around the hashing function, long overdue. Thanks for the report and PR!
Contributor
Author
|
Great! Thank you for your time and hard work on sftpretty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83