Repository navigation
fix(dataflow): collect local callback prop sites on demand - #456
Merged
Merged
Conversation
byronwall
marked this pull request as ready for review
November 22, 2026 21:11
byronwall
enabled auto-merge (squash)
November 22, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #441.
The forward demand collector could start inside a child component without loading the JSX occurrence that supplies its named callback prop. The existing binding pass already knew how to pair
onQuery={setQuery}with that occurrence once it collected the parent. The lazy path only requested callers forchildren.Discover named prop sites through the checker-backed component reference index and queue only matching JSX tag partitions carrying that prop. Reuse the existing occurrence-bound proof; the demand collector does not fall back to eager collection or make new claims about unresolved handlers. An unresolved supplied callback still reports a partial trace without a render destination.
Verified the actual React pattern catalog's lifted-state case (with a minimal React type shim): from the child event value, cold and shuffled demand results equal eager including the binding witness, query state, and query render terminal. The cold main case visits one source file and fewer than six statement partitions. The negative has an unresolved supplied callback and a separate same-name component, with no invented binding or render endpoint. 23 demand/parity/transport/lifecycle tests passed; engine typecheck and lint passed. Full local browser verification blocked by Chromium CDN HTTP 403; required browser CI runs on the PR.
Survey moves: none across 634 traces (102 client, 330 fixtures, 202 server).