Skip to content

fix(scan): share tracked source visibility across views - #455

Merged
byronwall merged 2 commits into
mainfrom
fix/tracked-ignored-inventory
Nov 22, 2026
Merged

byronwall merged 2 commits into
mainfrom
fix/tracked-ignored-inventory

Conversation

@byronwall

@byronwall byronwall commented Nov 22, 2026 •

Copy link
Copy Markdown
Owner

Fixes #440.

Summary

  • Use the Tree’s native Git file inventory for Imports and Symbols before applying their structural source filters. Tracked source stays visible even if it matches an ignore rule; ignored untracked files stay excluded. Preserve the pathspec fallback outside Git.
  • Build each structural view and cache key from one source list. Cache keys use exact paths, modification times, and sizes; in-root aliases share one resolved source, and links that leave the selected root never reach the structural parsers.
  • Explain why a file shown in the Tree may be ineligible for Imports or Symbols. Declaration, non-code, and vendor exclusions are covered; changed-file inventory is not touched.

Validation

  • Ruff and 80 focused server tests passed, including the cross-view caller-to-callee fixture, index-only and equal-mtime swaps, in-root alias swaps, and an external symlink exclusion.
  • Client typecheck and all 497 unit tests passed before the cache follow-up.
  • Full browser suite before the cache follow-up: 26 passed, 1 existing opt-in latency test skipped. The four focused Imports/Symbols browser tests passed again on the final tree.
  • Local Survey against 5c1b671 completed without a new trace error or a timing violation.

Survey moves: The Imports exclusion notice joins the selected file, the Tree’s metrics index, and the unfiltered Imports nodes. That explains the client’s aggregate unproven handoff +1 and external-code +2 without changing any trace outcome. Server external-code stops rose by 9 as source discovery reused the Git listing and added path/stat operations. The shared exact source key replaces the duplicate Symbols app/services/symbols/index.py#_signature helper, so its assumed trace dropped from the sample (server traces −1, assumed −1). No existing OK trace was lost, and no new trace errored.

@byronwall
byronwall marked this pull request as ready for review November 22, 2026 21:20
@byronwall
byronwall enabled auto-merge (squash) November 22, 2026 21:20
@byronwall
byronwall merged commit 86057bf into main Nov 22, 2026
9 of 10 checks passed
@byronwall
byronwall deleted the fix/tracked-ignored-inventory branch November 22, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use one repository inventory for the tree, Imports, and Symbols

1 participant