Repository navigation
fix(changes): open source at the selected revision - #452
Merged
Merged
Conversation
byronwall
marked this pull request as ready for review
November 22, 2026 20:22
byronwall
enabled auto-merge (squash)
November 22, 2026 20:22
byronwall
marked this pull request as draft
November 22, 2026 20:23
auto-merge was automatically disabled
November 22, 2026 20:23
Pull request was converted to draft
byronwall
marked this pull request as ready for review
November 22, 2026 20:25
byronwall
enabled auto-merge (squash)
November 22, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
scripts/check.sh client).uv run pytest -q tests/test_change_lens.py).Survey moves: The Changes source viewer now consumes the hunk response’s repository, revision, side, path, and line range before loading file content; it no longer goes straight from a selected chunk’s current scan path to the Treemap viewer. This intentionally introduces an API handoff, which the static survey cannot prove end to end. On the client it reports unproven handoff +3, unbound read +1, budget exhausted −3, disconnected −4, and unresolved symbol −12; these are aggregate stop deltas, not per-call attributions. On the server, the only new trace is
app/services/changelens/service.py#_source_location(assumed), which selects a source locator from the diff’s already-resolved refs and scopes, not from a separate filesystem read. The server’s aggregate stops shift filesystem −3 and external code −19. Neither side loses an existing OK trace or introduces a trace error. The Changes API and browser regressions exercise the revision handoff at runtime, including from the commit touch strip and when a historical blob is unavailable.