Skip to content

fix(dataflow): wait for a function before requesting effects - #450

Merged
byronwall merged 3 commits into
mainfrom
dot/fix-function-effects-no-selection
Nov 22, 2026
Merged

byronwall merged 3 commits into
mainfrom
dot/fix-function-effects-no-selection

Conversation

@byronwall

@byronwall byronwall commented Nov 22, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Opening a whole TypeScript or JavaScript file shows a prompt to choose a function rather than sending the file node's line-zero sentinel to the effects endpoint.
  • Picking a function still analyzes it, and returning to the whole file clears the result.
  • The API validates one-based line numbers and returns 422 for zero or negative values, before starting the engine.

Verification

  • Client typecheck and 492 tests passed. A focused DOM harness also verified no request for the whole file, a single request for the selected function, and no extra request on clearing.
  • Ruff and the two new FastAPI regression cases passed. With the real engine on the repository's synthetic ViewerCard fixture, line 0 returned 422 and line 3 returned 200 with ViewerCard effects.
  • Added a browser regression covering the whole-file → selected function → whole-file flow. Local Chromium could not start under the execution sandbox, so the browser run remains for CI.
  • No engine analysis rules changed.

Survey moves: client boundary: unproven-handoff +2, both on the already-partial src/compare/rows.ts#indexFiles trace. The whole-file fallback changes which existing CodeModal paths fit inside the unchanged 2,048-element walk budget. This walk now reaches the existing resource fetchers fetchFindings (FileFindings.tsx) and fetchCommits (RecentCommits.tsx), where invocation pairing is not proven. Their runtime calls and the engine are unchanged. All 102 client outcomes are unchanged, including FAMILY_WORDS (still ok); disconnected stops are unchanged.

@byronwall
byronwall marked this pull request as ready for review November 22, 2026 20:20
@byronwall
byronwall enabled auto-merge (squash) November 22, 2026 20:20
@byronwall
byronwall merged commit 5c1b671 into main Nov 22, 2026
8 of 9 checks passed
@byronwall
byronwall deleted the dot/fix-function-effects-no-selection branch November 22, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant