Skip to content

Plan standalone charts from data plus a config - #673

Merged
byronwall merged 1 commit into
mainfrom
claude/standalone-charts-plan
Nov 20, 2026
Merged

byronwall merged 1 commit into
mainfrom
claude/standalone-charts-plan

Conversation

@byronwall

@byronwall byronwall commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

This plans exploreda/chart: a <Chart data config /> React component that draws any explorEDA chart from plain rows and a partial config, with no workspace and no cross-chart filtering. It also covers <ChartSettings>, controlled editing through onConfigChange, and a scoped stylesheet. The plan records Byron's answers from three rounds of questions. The layers above build all four milestones; the top layer retires this plan.

What to do with it

Review the stack from the bottom. Each layer has its own proof. Merge the whole stack with gh stack merge 682 --yes.

Proof

The plan is based on the code at 1b4f57af:

  • The private docs kit (docsKit/ChartSettingsSurface.tsx) already drew one chart from data and settings with DataLayerProvider + ChartRenderer. Layer 2 makes this path public.
  • normalizeChart (lib/dsl/normalize.ts) already filled a partial chart from its type's defaults.
  • Charts select through updateChart(id, { filters }) (28 call sites), so one store flag turns selection off.
  • The provider already skipped a restore when incoming settings matched its state, so a controlled config does not loop.

The layers confirmed the two guesses. Every chart type renders outside the workspace (layer 2 tests, layer 6 example build). Portaled popovers take the scoped CSS once they mount inside the chart (layer 3). The example app found two problems the plan did not predict, and both are fixed: a Box plot crash in bundled apps (layer 3), and host element rules leaking into chart controls (layer 4).

Stack: standalone charts

What splits: a standalone chart API for package users. It splits into the plan, read-only Chart, scoped CSS with a proof app, controlled editing, Dashboard text configs, docs with retirement, short configs, a chart builder, and its craft pass.
Why it splits: each layer can be reviewed on its own proof. A smaller set can merge first: layers 1–3 alone give a safe read-only chart.
Why this split: the order follows risk. Drawing first, then style isolation (needed before any real host), then editing (new data flow), then the optional text config. Two other splits were rejected. One PR per chart type would repeat the same machinery 27 times. Splitting library from docs would leave each feature undocumented in its own layer, which the repo rules forbid.

  1. Plan standalone charts from data plus a config #673: the plan.
  2. Add Chart: one chart from rows and a config #674: read-only Chart, the exploreda/chart entry, and the docs page with every chart type.
  3. Scope chart styles; prove Chart in a separate app #675: scoped chart.css, portal layer, examples/standalone-charts, and the Box plot fix.
  4. Edit standalone charts at runtime #677: onConfigChange, ChartSettings, fields, and the host-to-chart style fix.
  5. Accept one line of Dashboard text as a chart config #678: Dashboard text as a config.
  6. Document standalone charts on every chart page; retire the plan #679: per-chart docs snippets, every type in the example app, and plan retirement.
  7. Report short configs; keep a chart's failure in its place #680: short configs from onConfigChange, and a per-chart error boundary.
  8. Add a chart builder to the docs #681: the chart builder at /docs/chart-builder.
  9. Polish the chart builder and standalone settings #682: the craft pass on the builder and standalone settings.

🤖 Generated with Claude Code

Add the docs/intent/standalone-charts plan for TASK-0051: an
exploreda/chart entry with Chart and ChartSettings, built on the
existing data layer. Record Byron's answers from three question rounds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant