Repository navigation
Plan standalone charts from data plus a config - #673
Merged
Merged
Conversation
Add the docs/intent/standalone-charts plan for TASK-0051: an exploreda/chart entry with Chart and ChartSettings, built on the existing data layer. Record Byron's answers from three question rounds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 20, 2026
byronwall
marked this pull request as ready for review
November 20, 2026 05:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plans
exploreda/chart: a<Chart data config />React component that draws any explorEDA chart from plain rows and a partial config, with no workspace and no cross-chart filtering. It also covers<ChartSettings>, controlled editing throughonConfigChange, and a scoped stylesheet. The plan records Byron's answers from three rounds of questions. The layers above build all four milestones; the top layer retires this plan.What to do with it
Review the stack from the bottom. Each layer has its own proof. Merge the whole stack with
gh stack merge 682 --yes.Proof
The plan is based on the code at
1b4f57af:docsKit/ChartSettingsSurface.tsx) already drew one chart from data and settings withDataLayerProvider+ChartRenderer. Layer 2 makes this path public.normalizeChart(lib/dsl/normalize.ts) already filled a partial chart from its type's defaults.updateChart(id, { filters })(28 call sites), so one store flag turns selection off.configdoes not loop.The layers confirmed the two guesses. Every chart type renders outside the workspace (layer 2 tests, layer 6 example build). Portaled popovers take the scoped CSS once they mount inside the chart (layer 3). The example app found two problems the plan did not predict, and both are fixed: a Box plot crash in bundled apps (layer 3), and host element rules leaking into chart controls (layer 4).
Stack: standalone charts
What splits: a standalone chart API for package users. It splits into the plan, read-only
Chart, scoped CSS with a proof app, controlled editing, Dashboard text configs, docs with retirement, short configs, a chart builder, and its craft pass.Why it splits: each layer can be reviewed on its own proof. A smaller set can merge first: layers 1–3 alone give a safe read-only chart.
Why this split: the order follows risk. Drawing first, then style isolation (needed before any real host), then editing (new data flow), then the optional text config. Two other splits were rejected. One PR per chart type would repeat the same machinery 27 times. Splitting library from docs would leave each feature undocumented in its own layer, which the repo rules forbid.
Chart, theexploreda/chartentry, and the docs page with every chart type.chart.css, portal layer,examples/standalone-charts, and the Box plot fix.onConfigChange,ChartSettings,fields, and the host-to-chart style fix.onConfigChange, and a per-chart error boundary./docs/chart-builder.🤖 Generated with Claude Code