Conversation
added 2 commits
April 13, 2020 15:32
- getting multiple errors in help-menu ``` Error: [$injector:modulerr] Failed to instantiate module helpMenuTopbar due to: [$injector:modulerr] Failed to instantiate module ngMaterial due to: [$injector:nomod] Module 'ngMaterial' is not available! ``` - and an unknown reference in unpaywall to 'bulibUnpaywallProvider' ``` Error: [$injector:unpr] Unknown provider: bulibUnpaywallProvider <- bulibUnpaywall ```
atla5
added
help wanted
added 4 commits
April 14, 2020 13:10
- still experiencing the 'Provider' errors, though: ``` Error: [$injector:unpr] Unknown provider: helpMenuContentDisplayProvider <- helpMenuContentDisplay ... Error: [$injector:unpr] Unknown provider: bulibUnpaywallProvider <- bulibUnpaywall ```
- still haven't fixed the injector
gpeterso
reviewed
Apr 16, 2020
Co-Authored-By: Jeff Peterson <gpeterso@users.noreply.github.com>
press 'F' to pay respects
- runs with node 6.9.2, but having xcode config errors with DEVELOPER_DIR, strangely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket: WEB-339
Background
UMNLibraries/primo-explore-hathitrust-availabilityhas some robust tests in a pretty lightweight wayprimo-explore-unpaywallandprimo-explore-help-menupackagesDescription of Changes
npm run startgoing to best enable users to test-run the changes locally