Fix PHP 8.4 ValueError when str_getcsv() receives empty enclosure#165
Open
richardlhr wants to merge 1 commit into
Open
Fix PHP 8.4 ValueError when str_getcsv() receives empty enclosure#165richardlhr wants to merge 1 commit into
richardlhr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a PHP 8+ compatibility issue in
SendPress_Data::csv_to_array().When
csv_to_array()is called without an enclosure argument, the default value is an empty string:This value is then passed directly to:
PHP 8+ now throws:
because the enclosure parameter must contain exactly one character.
Fix
Use the standard CSV enclosure character (
") when no enclosure is provided.This restores compatibility with PHP 8.x while preserving existing behavior.
Tested