Skip to content

More symlink improvements - #41

Merged
brandonchinn178 merged 5 commits into
mainfrom
symlinks
Sep 18, 2026
Merged

brandonchinn178 merged 5 commits into
mainfrom
symlinks

Conversation

@brandonchinn178

Copy link
Copy Markdown
Owner

Previously, we automatically resolved symlinks before passing the paths to hooky lint or other commands. But this isn't correct; git ls-files shows symlinks as a single file, so hooks should receive the same paths that git sees, and the hook command should be able to decide how to handle symlinks.

This PR adds a GitFile type that forces call-sites to decide how to handle files vs symlinks. This also allows us to consolidate the logic for resolving all the ways files may be specified.

@brandonchinn178
brandonchinn178 force-pushed the symlinks branch 2 times, most recently from 3370ac6 to 8533fe2 Compare September 18, 2026 03:21
@brandonchinn178
brandonchinn178 marked this pull request as ready for review September 18, 2026 05:41
@brandonchinn178
brandonchinn178 merged commit 2d29f10 into main Sep 18, 2026
2 checks passed
@brandonchinn178
brandonchinn178 deleted the symlinks branch September 18, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant