don't need convert map to objects anymore#231
Open
john (j13huang) wants to merge 2 commits into
Open
Conversation
Contributor
Hurshal Patel (choochootrain)
left a comment
Hurshal Patel (choochootrain)
left a comment
There was a problem hiding this comment.
tagging in Ken Jiang (@knjiang)
seems fine but we should make sure we dont break topics or gateway
Contributor
|
ya seems fine |
Ken Jiang (knjiang)
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to claude, we don't need the
convertMapsToObjectsfunction anymore because we serialize everything directly into json now?#191
So in theory we could do away with this extra overhead. Please tell me if this doesn't make sense