chore: Record stable span tree snapshots instead of heavily normalized payloads#2011
chore: Record stable span tree snapshots instead of heavily normalized payloads#2011Luca Forstner (lforst) wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Why use this mostly JSON text format rather than just using actual JSON with just a stable structure so we can actually do structural assertions on it? That way when something goes wrong we can better understand why and not just get some indecipherable string match failure. 🤔
A big motivation behind this change was to quickly understand what the instrumentation spits out. While a JSON gets us there, I found this format better for mentally parsing things like span type and especially hierarchy/relationships between spans. While getting this PR cleaned up, I haven't found diffs to be too hard to understand, however I see your point. Want me to change it? |
|
Can we have that as a debug output or something? I can see some value to that too, but I think for what actually gets asserted against I would slightly prefer something more structural. |
|
Stephen Belanger (@Qard) changed it so we are emitting both. I think the txt files are great for PR reviews so I still wanted it to be tracked via a file and not just process output. |
Replaces our admittedly random snapshots with received span tree snapshots that should make it better to reason about changes.