support more formats in attachment processor#107
Open
Andrew Kent (realark) wants to merge 4 commits into
Open
Conversation
Andrew Kent (realark)
force-pushed
the
ark/s3-images-other-providers
branch
2 times, most recently
from
51b1187 to
fac0707
Compare
| var span = spans.get(0); | ||
|
|
||
| assertEquals("anthropic.messages.create", span.getName()); | ||
| assertFalse(span.getName().isEmpty(), "span name should be non-empty"); |
Collaborator
Author
There was a problem hiding this comment.
making assertion less specific because spec tests will assert on the particular name
Andrew Kent (realark)
force-pushed
the
ark/s3-images-other-providers
branch
from
fac0707 to
2a2ff1f
Compare
Andrew Kent (realark)
force-pushed
the
ark/s3-images-other-providers
branch
from
2a2ff1f to
04b0ceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.