docs(infra): point the removed image check at #1045 - #1121
Merged
Conversation
Both comments left by #1120 read as though /api/config was never meant to carry an image list — "has no such field, and never has", "a contract the API does not implement". That is true of the code today and wrong about the intent: #1045 specifies `supportedImages` on that response, down to the same alias and ref the removed check asserted, and it is still open. Left as-is, the next reader concludes the field was a mistake rather than that the check outran the API work. Both comments now name #1045 as what reinstates the comparison and #1119 as why it went away. Comment text only; `git diff -U0` reports no changed executable line.
📦 BoxLite review — couldn't completepowered by BoxLite |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request updates comments in deployment and proxy verification scripts. The comments document deferred system-image comparison, related API issues, and the handling of legacy ChangesSystem-image verification documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
G4614
pushed a commit
to G4614/boxlite
that referenced
this pull request
Aug 3, 2026
…e-ai#1121) Both comments left by boxlite-ai#1120 read as though /api/config was never meant to carry an image list — "has no such field, and never has", "a contract the API does not implement". That is true of the code today and wrong about the intent: boxlite-ai#1045 specifies `supportedImages` on that response, down to the same alias and ref the removed check asserted, and it is still open. Left as-is, the next reader concludes the field was a mistake rather than that the check outran the API work. Both comments now name boxlite-ai#1045 as what reinstates the comparison and boxlite-ai#1119 as why it went away. Comment text only; `git diff -U0` reports no changed executable line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both comments left by #1120 read as though /api/config was never meant to
carry an image list — "has no such field, and never has", "a contract the
API does not implement". That is true of the code today and wrong about
the intent: #1045 specifies
supportedImageson that response, down tothe same alias and ref the removed check asserted, and it is still open.
Left as-is, the next reader concludes the field was a mistake rather than
that the check outran the API work. Both comments now name #1045 as what
reinstates the comparison and #1119 as why it went away.
Comment text only;
git diff -U0reports no changed executable line.Summary by CodeRabbit