Skip to content

docs(infra): point the removed image check at #1045 - #1121

Merged
DorianZheng merged 1 commit into
mainfrom
docs/point-image-check-at-1045
Aug 2, 2026
Merged

docs(infra): point the removed image check at #1045#1121
DorianZheng merged 1 commit into
mainfrom
docs/point-image-check-at-1045

Conversation

@DorianZheng

@DorianZheng DorianZheng commented Aug 2, 2026

Copy link
Copy Markdown
Member

Both comments left by #1120 read as though /api/config was never meant to
carry an image list — "has no such field, and never has", "a contract the
API does not implement". That is true of the code today and wrong about
the intent: #1045 specifies supportedImages on that response, down to
the same alias and ref the removed check asserted, and it is still open.

Left as-is, the next reader concludes the field was a mistake rather than
that the check outran the API work. Both comments now name #1045 as what
reinstates the comparison and #1119 as why it went away.

Comment text only; git diff -U0 reports no changed executable line.

Summary by CodeRabbit

  • Documentation
    • Updated internal comments to clarify the planned system-image comparison behavior and its relationship to the configuration API.
    • Added historical context and issue references for the unavailable supported-images field.

Both comments left by #1120 read as though /api/config was never meant to
carry an image list — "has no such field, and never has", "a contract the
API does not implement". That is true of the code today and wrong about
the intent: #1045 specifies `supportedImages` on that response, down to
the same alias and ref the removed check asserted, and it is still open.

Left as-is, the next reader concludes the field was a mistake rather than
that the check outran the API work. Both comments now name #1045 as what
reinstates the comparison and #1119 as why it went away.

Comment text only; `git diff -U0` reports no changed executable line.
@DorianZheng
DorianZheng requested a review from a team as a code owner August 2, 2026 12:51
@boxlite-agent

boxlite-agent Bot commented Aug 2, 2026

Copy link
Copy Markdown

📦 BoxLite review — couldn't complete

claude exited 1

stdout:
{"is_error":true,"duration_api_ms":0,"num_turns":1,"stop_reason":"stop_sequence","session_id":"b5dd9505-883d-4e49-a975-91de9ec150ff","total_cost_usd":0,"usage":{"input_tokens":0,"cache_creation_input_tokens":0,"cache_read_input_tokens":0,"output_tokens":0,"server_tool_use":{"web_search_requests":0,"web_fetch_requests":0},"service_tier":"standard","cache_creation":{"ephemeral_1h_input_tokens":0,"ephemeral_5m_input_tokens":0},"inference_geo":"","iterations":[],"speed":"standard"},"modelUsage":{},"permission_denials":[],"terminal_reason":"api_error","fast_mode_state":"off","fast_mode_disabled_reason":"sdk_opt_in_required","subtype":"success","api_error_status":403,"result":"Your organization has disabled Claude subscription access for Claude Code · Use an Anthropic API key instead, or ask your admin to enable access","type":"result","duration_ms":781,"uuid":"d8c752e4-d619-4c35-8007-762190c6984e"}

stderr:
<empty>

powered by BoxLite

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60a20c4e-93bc-4959-b1d0-30050e84f8a2

📥 Commits

Reviewing files that changed from the base of the PR and between caeff69 and d217bf3.

📒 Files selected for processing (2)
  • apps/infra/scripts/deployment-environment.mjs
  • apps/infra/scripts/proxy-deployment-verify.test.mjs

📝 Walkthrough

Walkthrough

The pull request updates comments in deployment and proxy verification scripts. The comments document deferred system-image comparison, related API issues, and the handling of legacy BOXLITE_SYSTEM_IMAGES values.

Changes

System-image verification documentation

Layer / File(s) Summary
Clarify deferred image verification
apps/infra/scripts/deployment-environment.mjs, apps/infra/scripts/proxy-deployment-verify.test.mjs
Comments now describe the pending /api/config image-list field, related issues, the premature image comparison, and unsupported assertions for legacy image values.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: ltstriker

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the intent and scope but omits the required Call graph, Changes, and How to verify sections. Add the required template headings, include the before-and-after call graph, list the notable changes, and provide a reviewer verification step.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and the issue that restores the removed image check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/point-image-check-at-1045

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DorianZheng
DorianZheng merged commit ff2f6a5 into main Aug 2, 2026
31 of 32 checks passed
@DorianZheng
DorianZheng deleted the docs/point-image-check-at-1045 branch August 2, 2026 12:52
G4614 pushed a commit to G4614/boxlite that referenced this pull request Aug 3, 2026
…e-ai#1121)

Both comments left by boxlite-ai#1120 read as though /api/config was never meant
to
carry an image list — "has no such field, and never has", "a contract
the
API does not implement". That is true of the code today and wrong about
the intent: boxlite-ai#1045 specifies `supportedImages` on that response, down to
the same alias and ref the removed check asserted, and it is still open.

Left as-is, the next reader concludes the field was a mistake rather
than
that the check outran the API work. Both comments now name boxlite-ai#1045 as what
reinstates the comparison and boxlite-ai#1119 as why it went away.

Comment text only; `git diff -U0` reports no changed executable line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant