Gate custom kernels behind an RC opt-in - #1051
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
📝 WalkthroughWalkthroughThis PR moves custom-kernel support into an experimental module, adds explicit ChangesCustom kernel RC
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant RuntimeBuilder
participant BoxliteRuntime
participant LocalRuntime
CLI->>CLI: Parse BOXLITE_EXPERIMENTAL
CLI->>RuntimeBuilder: Apply ExperimentalFeatures
RuntimeBuilder->>BoxliteRuntime: Build runtime
BoxliteRuntime->>LocalRuntime: Create with feature state
LocalRuntime->>LocalRuntime: Validate custom-kernel options
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
tester seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
tester seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📦 BoxLite review — looks good ·
|
Custom kernels (#1041, #1051) and the capability policy both extend `AdvancedBoxOptions`, the CLI flag set, and option validation, so the two features are combined rather than either replacing the other. Capability name validation moves to `sanitize_common`, which main split out of `sanitize`: a capability list is request data, not a filesystem source, so it must also be checked on the persisted path. The warm-pool capability test now stubs `organizationUsageService`, which the org-quota work (#1028) made a required collaborator of `BoxService::create`.
Summary
boxlite::experimentalnamespaceBOXLITE_EXPERIMENTAL=custom-kernelonce in the CLI and inject typed feature state into the runtimeWhy
Custom-kernel support is release-candidate functionality. It should remain available for deliberate testing without appearing as a stable, discoverable feature. Unknown experimental tokens fail closed.
Impact
CLI callers must set
BOXLITE_EXPERIMENTAL=custom-kernelbefore using custom-kernel flags. Rust callers opt in throughRuntimeBuilderand the experimental API. The REST API does not expose the feature.Validation
make clippymake fmt:checkThe native CLI build was not repeated because this worktree's vendored libkrun submodules are uninitialized; the focused CLI tests used the repository's dependency-stub/linker workaround.
Summary by CodeRabbit
New Features
BOXLITE_EXPERIMENTAL=custom-kerneland Rust SDK configuration.Documentation
Bug Fixes