fix: external trampoline type checking#494
Open
nicklafleur wants to merge 1 commit intoboxed:mainfrom
Open
Conversation
Changes: - Detects the `Self` annotation and replaces it with generics in mutated functions to support type checking - Normalize external trampoline naming conventions to the established patterns (this had some side-effects with type checking as well) Tests: - add tests that validate inheritence of class/static methods passes type checking with the generic replacement Ref: boxed@c866681
1235805 to
e6a9ff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues introduced in #476
Changes:
Selfannotation and replaces it with generics in mutated functions to support type checkingTests:
Ref: c866681