Skip to content

perf: Wait for parallel workers with stream_select() when progress is disabled - #520

Merged
samsonasik merged 12 commits into
mainfrom
perf-stream-select
Oct 26, 2026
Merged

samsonasik merged 12 commits into
mainfrom
perf-stream-select

Conversation

@samsonasik

@samsonasik samsonasik commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Without progress (--no-progress, --report=json|github, PHPUnit extension with progress off)

Files / workers Loop passes usleep(5000) fread() calls Wall time Coordinator CPU
40 / 2 main 33 31 64 194.0 ms 1.9 ms
this PR 2 0 2 191.2 ms 1.6 ms
2000 / 12 main 169 160 1340 1066.8 ms 45.0 ms
this PR 12 0 12 1069.0 ms 40.2 ms

With progress: unchanged, as the same 5 ms poll still batches the workers' progress lines.

Files / workers Loop passes usleep(5000) fread() calls Wall time Coordinator CPU
40 / 2 main 24 13 46 197.2 ms 1.8 ms
this PR 24 13 46 196.7 ms 1.8 ms
2000 / 12 main 228 134 1972 1075.0 ms 49.7 ms
this PR 226 134 1972 1060.1 ms 47.8 ms

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@samsonasik samsonasik closed this Oct 26, 2026
@samsonasik
samsonasik deleted the perf-stream-select branch October 26, 2026 03:34
@samsonasik
samsonasik restored the perf-stream-select branch October 26, 2026 12:15
@samsonasik samsonasik reopened this Oct 26, 2026
@samsonasik
samsonasik merged commit 51d8e96 into main Oct 26, 2026
13 of 14 checks passed
@samsonasik
samsonasik deleted the perf-stream-select branch October 26, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant