Fix missing kwargs in load/reload documentation - #4841
Open
aoright wants to merge 1 commit into
Open
Conversation
Fixes boto#3498. Previously, `document_load_reload_action` passed an empty `OperationModel` when generating documentation for `load()` and `reload()` methods, which resulted in an empty method signature. This PR changes it to extract the underlying operation model (e.g., `HeadObject`) and passes it to `document_model_driven_resource_method`, successfully restoring the arguments and their types in the generated documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing kwargs in load/reload documentation
Fixes #3498.
Previously,
document_load_reload_actionpassed an emptyOperationModelwhen generating documentation forload()andreload()methods, which resulted in an empty method signature. This PR changes it to extract the underlying operation model (e.g.,HeadObject) and passes it todocument_model_driven_resource_method, successfully restoring the arguments and their types in the generated documentation.