fix: DynamoDB placeholder generation no longer overwrites caller values - #4836
Open
TrueFurina wants to merge 2 commits into
Open
TrueFurina wants to merge 2 commits into
TrueFurina wants to merge 2 commits into
Conversation
Author
|
Nudging this politely. The behavioral delta is narrow: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4831
Problem: ConditionExpressionBuilder restarts placeholder numbering at #n0/:v0 on every request, and the generated placeholders are merged over the caller's with dict.update — so a caller-supplied #n0/:v0 gets silently overwritten and the expression resolves to the wrong value.
Fix: after reset(), start placeholder numbering after the highest #n / :v index the caller already provided, so generated placeholders never collide with the caller's ExpressionAttributeNames/ExpressionAttributeValues.