Open
Conversation
keyformatter updates
get KeyFormatter printing
cdpr_planar, cdpr_planar_sim, and cdpr_controller_tension_dist all passing now
bugfix/gerry/python_jacobianfactor_rtti Be sure to manually set linearSolverType to QR, or use the MyLMParams() function in utils, or else the optimizer won't work properly.
* Key functions are no longer internal * values functions remove "Double" template parameter
Member
|
Well, you have to add (one) reviewer. If you add me, I'll say: can you please split it up in a few, easy to review PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges in updates to the cable robot code. I should have made this PR a long time ago and also split up changes into separate PR's, but I kept procrastinating.
Updates include:
cdpr_planar_controllerto be a Base class that supports both iLQR and "naive" controllersgerry02-gerry04paint_parseutils.py[torque1; torque2; torque3; torque4] = K * [pose ; twist]so we would like to group the torques (which are currently 4 scalar variables) together and the pose+twist together.