Skip to content

tmt: Fix var-mount test to use booted container image #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckyrouac wants to merge 1 commit into from
+12 −21
Closed

tmt: Fix var-mount test to use booted container image #1927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 12 additions & 21 deletions tmt/tests/booted/test-install-to-filesystem-var-mount.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,20 @@

set -xeuo pipefail

# Use a generic target image to test skew between the bootc binary doing
# the install and the target image
TARGET_IMAGE="docker://quay.io/centos-bootc/centos-bootc:stream10"
# Build a derived image with LBIs removed for installation
TARGET_IMAGE="localhost/bootc-install"

echo "Testing bootc install to-filesystem with separate /var mount"

# Disable SELinux enforcement for the install
setenforce 0
# Copy the currently booted image to container storage for podman to use
bootc image copy-to-storage

# Enable usr-overlay to allow modifications
bootc usr-overlay

# Install required packages (bootc images are immutable, so we need to install
# after usr-overlay is enabled)
dnf install -y parted lvm2 dosfstools e2fsprogs

# Mask off conflicting ostree state
if test -d /sysroot/ostree; then
mount --bind /usr/share/empty /sysroot/ostree
fi
rm -vrf /usr/lib/bootupd/updates
rm -vrf /usr/lib/bootc/bound-images.d
# Build a derived image that removes LBIs
Copy link
Collaborator

@cgwalters cgwalters Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant to ask before also - why are we doing this? How do LBIs relate to this issue?

Is it about saving disk space?

Copy link
Collaborator Author

@ckyrouac ckyrouac Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small optimization to avoid pulling the LBIs into the TMT test VM's container storage for the bootc install.

Copy link
Collaborator

@cgwalters cgwalters Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. But let's try to ensure that we include rationale for things like this in comments and commit messages.

cat > /tmp/Containerfile.drop-lbis <<'EOF'
FROM localhost/bootc
RUN rm -rf /usr/lib/bootc/bound-images.d/*
EOF
podman build -t "$TARGET_IMAGE" -f /tmp/Containerfile.drop-lbis

# Create a 12GB sparse disk image in /var/tmp (not /tmp which may be tmpfs)
DISK_IMG=/var/tmp/disk-var-mount-test.img
Expand Down Expand Up @@ -91,7 +83,7 @@ vgcreate BL "$LVM_PART"

# Create logical volumes
lvcreate -L 4G -n var02 BL
lvcreate -L 5G -n root02 BL
lvcreate -l 100%FREE -n root02 BL

# Create filesystems on logical volumes
mkfs.ext4 -F /dev/BL/var02
Expand Down Expand Up @@ -122,8 +114,7 @@ echo "Filesystem layout:"
mount | grep /var/mnt/target || true
df -h /var/mnt/target /var/mnt/target/boot /var/mnt/target/boot/efi /var/mnt/target/var

# Run bootc install to-filesystem
# This should succeed and handle the separate /var mount correctly
# Run bootc install to-filesystem from within the container image under test
podman run \
--rm --privileged \
-v /var/mnt/target:/target \
Expand Down
Loading