-
Notifications
You must be signed in to change notification settings - Fork 169
utils: Always print status to stderr #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly redirects spinner status messages to stderr, preventing them from corrupting JSON output on stdout. The changes in the Rust code are logical, and the updated test case is a significant improvement, effectively verifying the fix. I've included a couple of suggestions to enhance the robustness of both the application code and the test script.
|
We might hitting an grub2 regression injected in fedora-bootc:44 |
If we were waiting on a lock as part of `bootc status --format=json` this information message would end up in stderr, corrupting the output. Signed-off-by: Colin Walters <[email protected]>
3fd0b4e to
4d5f8de
Compare
|
Rebased to pick up #1908 |
|
Hm the |
➡️ #1910 |
Yeah, it's technically not gating right now (but probably should be) |
If we were waiting on a lock as part of
bootc status --format=jsonthis information message would end up in stderr, corrupting the output.