shelley skills: follow symlinks in Discover() #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.ReadDir returns DirEntry values whose IsDir() reports the symlink's own type, not the target's. When skill directories are symlinks (e.g. in ~/.config/agents/skills/), Discover() skipped them all. Use os.Stat on the resolved path to follow symlinks. References: boldsoftware#83 Co-authored-by: Shelley <[email protected]>
Amolith
force-pushed
the
fix/skills-loading-outside-home
branch
from
03dbe28 to
1bdf85b
Compare
Amolith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.ReadDirreturnsDirEntryvalues whoseIsDir()reports the symlink's own type, not the target's. When skill directories are symlinks,Discover()skipped them all.Use
os.Staton the resolved path to follow symlinks.Fixes: #83