Skip to content

Upgrade to Node 24 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrbeilke wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Upgrade to Node 24 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
648e369
feat: Bump runtime to Node 24
jrbeilke Apr 14, 2026
305dcca
ci: upgrade workflows to Node 24 and latest action versions
jrbeilke Apr 14, 2026
8dc82b6
ci: bump third-party actions to node24 versions
jrbeilke Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions .github/workflows/cleanup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,11 @@ jobs:
matrix:
scenario: [ 'success', 'failure' ]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: '18'

# Dependencies
# https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action
- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
node-version: '24'
cache: 'npm'
- run: npm install

@nschonni nschonni May 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: npm install
- run: npm ci

- run: npm run build

Expand All @@ -37,7 +24,7 @@ jobs:
shell: bash
env:
PR_HEAD: ${{ github.head_ref }}
run: echo "##[set-output name=branch;]$(echo ${PR_HEAD#refs/heads/} | tr / -)"
run: echo "branch=$(echo ${PR_HEAD#refs/heads/} | tr / -)" >> $GITHUB_OUTPUT

- name: delete environment
uses: ./
Expand Down
44 changes: 11 additions & 33 deletions .github/workflows/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,13 @@ jobs:
runs-on: ubuntu-latest
steps:
# Environment
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: '18'
node-version: '24'
cache: 'npm'

# Dependencies
# https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action
- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
- run: npm install

# Checks
Expand All @@ -48,31 +37,20 @@ jobs:
exit_code: 1
fail-fast: false
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: '18'
node-version: '24'
cache: 'npm'

# Dependencies
# https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action
- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
- run: npm install
- run: npm run build

- name: extract branch name
id: get_branch
shell: bash
run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/} | tr / -)"
run: echo "branch=$(echo ${GITHUB_REF#refs/heads/} | tr / -)" >> $GITHUB_OUTPUT

- name: start deployment
uses: ./
Expand All @@ -94,7 +72,7 @@ jobs:


- name: assert deployment in progress
uses: actions/github-script@v6
uses: actions/github-script@v9
env:
deployment_id: ${{ steps.deployment.outputs.deployment_id }}
status_id: ${{ steps.deployment.outputs.status_id }}
Expand Down Expand Up @@ -131,7 +109,7 @@ jobs:
debug: true

- name: assert deployment complete
uses: actions/github-script@v6
uses: actions/github-script@v9
env:
deployment_id: ${{ steps.deployment.outputs.deployment_id }}
status_id: ${{ steps.finish.outputs.status_id }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v2
uses: actions/checkout@v6
- name: update tag
run: |
git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com"
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ branding:
icon: bookmark
color: yellow
runs:
using: node20
using: node24
main: dist/index.js

inputs:
Expand Down
40 changes: 31 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"devDependencies": {
"@vercel/ncc": "0.36.0",
"@types/js-yaml": "4.0.5",
"@types/node": "18.11.18",
"@types/node": "24.x",
"prettier": "2.8.3",
"typescript": "4.9.4"
}
Expand Down
Loading