Repository navigation
[DOCS] fix broken logo image on docs landing pages - #81
Merged
Merged
Conversation
The locale index pages were copied from README.md and still pointed at .github/fastkit_general_logo.png, which does not exist on the built site. Point them at img/fastkit_general_logo.png, which mkdocs-static-i18n copies under every locale. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The logo at the top of https://bnbong.github.io/FastAPI-fastkit/ (and every locale landing page) did not render. The 7
docs/*/index.mdfiles were copied from README.md and still referenced.github/fastkit_general_logo.png, a path that only exists in the GitHub repo view, not on the built site.This changes the
srctoimg/fastkit_general_logo.png. The image already lives indocs/img/, and mkdocs-static-i18n copies it under each locale, so the relative path resolves for/,/ko/,/ja/, etc.Verification
mkdocs build --strictpasses with no warnings.img/fastkit_general_logo.png, and the file exists insite/img/andsite/<locale>/img/.Note: the docs deploy workflow runs on pushes to
main, so the live site updates once this reachesmain.🤖 Generated with Claude Code