Use consistent names for all selection methods#34
Merged
Conversation
Previously, the names of items changed based on how they were selected. Selecting bodies directly used only the body name, while selecting components included the component names as well. Selecting the root component would then include the document name and the name of all intermediate components. In the the new model, we always exclude the root component and always name the item using the full path from the root, including all intermediate components. This means you can no longer get only body names, but that will be fixed by a future option. This also fixes a bug where you could end up selecting both bodies and components and end up with duplicate items. This was particularly easy to do if you used drag selection and the origin was visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the names of items changed based on how they were selected. Selecting bodies directly used only the body name, while selecting components included the component names as well. Selecting the root component would then include the document name and the name of all intermediate components.
In the the new model, we always exclude the root component and always name the item using the full path from the root, including all intermediate components. This means you can no longer get only body names, but I'll fix that with a future option.
This also fixes a bug where you could select both bodies and components and end up with duplicate items. This was particularly easy to do if you used drag selection and the origin was visible.
Fixes #20.
Also helps with #29 and #30, but those are not fully addressed until I add the extra options.