fix(desktop): resolve overlapping mention recipients by span#2939
fix(desktop): resolve overlapping mention recipients by span#2939yinkev wants to merge 2 commits into
Conversation
|
@codex review |
709ebbd to
97f3c3a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97f3c3a2c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Kevin Yin <182213728+yinkev@users.noreply.github.com>
97f3c3a to
cc3fe80
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc3fe80bae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
useMentions.tsbelow the repository's file-size limitBefore this change,
@OriginalName copymatched bothOriginalNameandOriginalName copy, so Desktop emitted twoptags and could start two distinct managed agents even though the composer visibly named only the copy.Related issue
Fixes #2909
No competing implementation was found before opening this PR. Related historical mention work addresses autocomplete or other routing mechanisms, not outgoing overlapping-span tag extraction.
Testing
pnpm typecheckpnpm buildgit diff --checkThe repository-wide
just cifrontend file-size step still reports the existing untoucheddesktop/src-tauri/src/managed_agents/runtime.rsupstream violation. PR #2930 restores that ratchet without changing runtime behavior and has a fully successful GitHub CI run. After extracting the new recipient helper,useMentions.tsremains below its 1,000-line limit.