This repository was archived by the owner on Apr 3, 2019. It is now read-only.
improve Transaction._estimateFee() precision#277
Open
lpinca wants to merge 1 commit intobitpay:masterfrom
Open
improve Transaction._estimateFee() precision#277lpinca wants to merge 1 commit intobitpay:masterfrom
lpinca wants to merge 1 commit intobitpay:masterfrom
Conversation
lpinca
force-pushed
the
fix/estimate-fee-per-kb
branch
from
c1091ab to
49cd527
Compare
Use the binary interpretation of kilobyte (1024 bytes) and return the correct amount of satoshis.
lpinca
changed the title
lpinca
force-pushed
the
fix/estimate-fee-per-kb
branch
from
49cd527 to
ee95295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the binary interpretation of kilobyte (1024 bytes) and return the correct amount of satoshis.
With default parameters and a transaction size of 1024 bytes I expect a fee of 10000 satoshis. The actual result is currently 20000 satoshis.