This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Read address version as unsigned integer#137
Open
gabmontes wants to merge 1 commit intobitpay:masterfrom
bloq:unsigned_address_version
Open
Read address version as unsigned integer#137gabmontes wants to merge 1 commit intobitpay:masterfrom bloq:unsigned_address_version
gabmontes wants to merge 1 commit intobitpay:masterfrom
bloq:unsigned_address_version
Conversation
That prevents large address versions to be read as negative numbers and failing to lookup the correct network from the Networks map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents large address versions (larger than 0x7fffffff) to be read as negative numbers and failing to lookup the correct network from the Networks map.
Large address versions could eventually be found in custom network definitions. We had do create a custom network and address version resulted in a large numbers in order for the HD private/public keys to have the initial chars as desired. As the library read those large number as negative, it was unable to find the network in the
networkMapsfor certain operations.