Skip to content

ci: remove slow and inefficient cargo caching#2129

Open
harrshita123 wants to merge 1 commit intobitcoindevkit:masterfrom
harrshita123:optimize-ci-caching
Open

ci: remove slow and inefficient cargo caching#2129
harrshita123 wants to merge 1 commit intobitcoindevkit:masterfrom
harrshita123:optimize-ci-caching

Conversation

@harrshita123
Copy link

Description

This PR disables Cargo caching in GitHub Actions as recommended in #1637. Compressing and uploading the cache was consistently taking longer than the actual builds, slowing down the feedback loop.

I've also included a fix for bdk_esplora compilation failures. The build was breaking due to -D warnings and the deprecation of get_blocks in the latest esplora-client. I've migrated the extensions to use get_block_infos.

Notes to the reviewers

  • Disabling caching in cont_integration.yml, code_coverage.yml, and zizmor.yml.
  • The esplora fix was required to get CI passing, as the deprecation warnings were blocking the build.
  • Fixed field access from .time.height to .height as per the new BlockInfo struct.

Changelog notice

  • ci: remove inefficient cargo caching in workflows (Remove CI Caching step #1637)
  • fix(esplora): migrate from deprecated get_blocks to get_block_infos

Checklists

All Submissions:

Bugfixes:

@Serious-Sam-Dev
Copy link

maybe split this in two commits, once to remove cache and another to fix esplora, is better than leave all in once commit, and try use conventional commits to call more attention of maintainers to review your PR. Another thing, i dont know if this is must relevant to the project now, i think fix ci is important but maybe is better join this in a PR with more chores of BDK, look for CONTRIBUTING she say to try give more substance to the commits, again i think this CI fix matters, but i dont know if you got a review fast

@va-an
Copy link

va-an commented Feb 27, 2026

bdk_esplora was already fixed and merged in #2130.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants