Open
Conversation
bilalba
reviewed
Nov 7, 2016
Owner
bilalba
left a comment
There was a problem hiding this comment.
The plugin is already available on Package Control https://packagecontrol.io/packages/InputArgs
Also, this plugin is an extension to the original build system and I did not change the bug-relevant portion. It means that the bug is a part of the original build system. I will soon verify this and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fifth argument for AsyncProcess is a string (
path) and the sl being passed in is a dict with additional kwargs from the build process (e.g., in my case it just says { "shell": true }, which throws astr expected, not dicterror.Passing in this path doesn't seem to be necessary anyway.
Also added an example build file because I had accidentally put
cmdrather thanshell_cmd.Do you think you might put this on PackageControl? If not, do you mind if I do?