Skip to content

Conversation

@alangecker
Copy link
Collaborator

MrWaffelXD and others added 25 commits July 21, 2024 22:13
update bbb-build container tag
This still listed old (now removed) containers and missed newly added
ones, which are now fixed.

This also makes the network_mode: host listings consistent, and removes
the "extra_hosts" listed for nginx (this does not really seem to have
much advantage in docs, unlike a list of allocated IP addresses which
*is* useful).

The list is slightly reordered to match the order in
docker-compose.tmpl.yml.
This is not really needed, nginx is always intended to be behind a
reverse proxy, so it can just expose its ports on the internal network.
This prevents having the 4808x ports exposed externally (though a user
can still expose them explicitly with a ports directive if needed).

This removes the "nginx" extra-hosts definition from the
bbb-graphql-middleware host container, since the "nginx" name now
resolves to the nginx internal IP normally.

In the haproxy config, this updates the IP address instead of using the
"nginx" name, as it seems that the haproxy resolv.conf does not list the
docker resolver but somehow uses the (host system) external DNS
directly.

Nginx also listens on port 8185. Previously this bound to 127.0.0.1 and
10.7.7.1 (the host-side IP of the internal network) explicitly,
presumably to prevent this port being available publically, but this is
no longer needed, so now it can just bind to the port directly.
This is not really needed, haproxy only needs to expose two ports
externally, so better to make that explicit using a ports directive,
which also gives the user more control.
These directories were marked as volumes in their dockerfile, but
nothing was explicitly mounted on them. This makes docker create an
unnamed volume and mount that when the container is created, which means
that on every down/up cycle, it would leave two unnamed volumes
lingering around.

Explicitly mounting these data directories prevents this.
…e across docker-compose, office-convert.sh, etherpad-export.sh, and sample.env
Add restart policy to HAProxy container
feat(bbb-docker): Add enable switches for **Collabora** and **Coturn** + make Collabora URL configurable
Add missing volume mounts for coturn and redis
fixed a dependency issue which led to an error during build
Stop using network_mode: host for nginx and haproxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants