Open
Conversation
- Use stdatomic.h on MinGW instead of MSVC Interlocked functions. MinGW defines _WIN32 but has <stdatomic.h> unlike MSVC. Fix guards in utilPth.c and sswPart.c. - Exclude -ldl and -lrt from link libraries on MINGW/MSYS platforms, as these Unix-only libraries don't exist on MinGW. - Add -lshlwapi on MINGW/MSYS for PathMatchSpec used in sclLiberty.c. Co-developed-by: Claude Code v2.1.39 (claude-opus-4-6)
Add a new GitHub Actions workflow for building ABC with MinGW/MSYS2 on Windows. This provides an alternative Windows build path using the GNU toolchain via MSYS2's mingw-w64-x86_64-gcc. The workflow uses ABC_USE_STDINT_H=1 and -DWIN32 -DWIN32_NO_DLL flags to handle MinGW platform quirks (32-bit long on 64-bit Windows, missing WIN32 define in MinGW). Co-developed-by: Claude Code v2.1.39 (claude-opus-4-6)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for building ABC with MinGW/MSYS2 on Windows, providing an alternative Windows build path using the GNU toolchain.
Build fixes (commit 1)
stdatomic.hon MinGW instead of MSVCInterlockedfunctions. MinGW defines_WIN32but has<stdatomic.h>unlike MSVC — fix guards inutilPth.candsswPart.c.-ldland-lrtfrom link libraries on MINGW/MSYS platforms (these Unix-only libraries don't exist on MinGW).-lshlwapion MINGW/MSYS forPathMatchSpecused insclLiberty.c.New CI workflow (commit 2)
build-mingw.ymlworkflow (does not modify any existing workflow files).mingw-w64-x86_64-gcconwindows-latest.ABC_USE_STDINT_H=1and-DWIN32 -DWIN32_NO_DLLflags to handle MinGW platform quirks (32-bitlongon 64-bit Windows, missingWIN32define).Test plan