Use in-workflow MCP server via in-memory transport#7
Draft
dandavison wants to merge 2 commits intobergundy:mainfrom
Draft
Use in-workflow MCP server via in-memory transport#7dandavison wants to merge 2 commits intobergundy:mainfrom
dandavison wants to merge 2 commits intobergundy:mainfrom
Conversation
dandavison
force-pushed
the
workflow-mcp-server
branch
from
060d51f to
733b867
Compare
Use released sdk-python
dandavison
force-pushed
the
workflow-mcp-server
branch
from
733b867 to
e573042
Compare
dandavison
commented
Aug 22, 2025
| from temporalio.worker import Worker | ||
|
|
||
| from nexusmcp import WorkflowTransport | ||
| import nexusmcp.workflow |
Contributor
Author
There was a problem hiding this comment.
This would go into the Temporal SDK eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
WorkflowTransportwith in-workflowmcp.server.lowlevel.Server.EDIT: Instead of this PR, I'm going to investigate removing the forward proxy MCP server from the NonWFCaller inbound gateway, and just using
ClientSessionthere.Advantages
Before this PR, workflow caller and non-workflow caller pathways were different:
The workflow caller did not have any
mcp.server.lowlevel.Serverhandling MCP details; this would inevitably have resulted in bugs and inconsistencies.Now they are the same:
It is also a substantial code simplification.
Disadvantages