fix: recv_timeout option now respected for pooled connections#833
Merged
fix: recv_timeout option now respected for pooled connections#833
Conversation
Previously, when using connection pooling, the recv_timeout option passed to hackney:request/5 was ignored. Pooled connections used the timeout from when they were created. Now recv_timeout is extracted from Options and passed through ReqOpts to hackney_conn, where it updates conn_data.recv_timeout per-request for HTTP/1.1, HTTP/2, HTTP/3, and async request paths. Fixes #832
benoitc
force-pushed
the
fix/recv-timeout-pooled-connections
branch
from
3e050d4 to
2b074ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recv_timeoutoption was ignored for pooled connectionsrecv_timeoutthroughReqOptstohackney_connfor per-request timeout updates