change: Updated how to add Custom ILoggerProvider#55
Open
DiasAtBeamable wants to merge 1 commit intocore/v7.1from
Open
change: Updated how to add Custom ILoggerProvider#55DiasAtBeamable wants to merge 1 commit intocore/v7.1from
DiasAtBeamable wants to merge 1 commit intocore/v7.1from
Conversation
updated how to ad a custom ILoggerProvider to a microservice after code changes.
| ``` | ||
|
|
||
| ## Setting a custom logger | ||
| # Setting a custom logger |
Contributor
There was a problem hiding this comment.
I don't think this should be a "title heading"; instead, I think it should continue to be a major heading (two ##) and the "Example" section should be a sub-heading (three ###)
allister-beamable
approved these changes
Apr 2, 2026
Contributor
allister-beamable
left a comment
allister-beamable
left a comment
There was a problem hiding this comment.
I like the improvements to tighten up the wording and use the more official-looking ".NET" styling. I think the Markdown headings need a bit of adjustment, but other than that, this is good to go!
| ``` | ||
|
|
||
| ## Setting a custom logger | ||
| # Setting a custom logger |
Contributor
There was a problem hiding this comment.
Suggested change
| # Setting a custom logger | |
| ## Setting a Custom Logger |
| | `defaultProcessor` | `DebugLogProcessor` | The default ZLogger async log processor that Beamable has already set up | | ||
| | **returns** | `DebugLogProcessor` | The processor that should actually be used — return `defaultProcessor` or `null` to keep the default, return a new instance to replace it | | ||
|
|
||
| ## Example: |
Contributor
There was a problem hiding this comment.
Suggested change
| ## Example: | |
| ### Example of Logger Override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the guide section created on PR 50 to match the new changes made in code.