-
Notifications
You must be signed in to change notification settings - Fork 11
Add proposal for support for init segments in Flows #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j616
wants to merge
16
commits into
main
Choose a base branch
from
jamessa-flowInitSegments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b5281a0
Add ADR0045 on Flow init segment support
j616 5b610a3
Updates following discussion at TAMSCon
j616 b9d4fa9
Updates following feedback from CMAF specialists
j616 8f6f351
Select option 5 in ADR0045
j616 6bf4b3c
Re-categorize Option 6's potential unintuitiveness as Bad following f…
j616 753f20c
Add init segment support to specification
j616 b3b3ac6
Use `video/iso.segment` in fmp4 Flow example.
j616 02a5555
Add Application Note 0024 describing init segment usage
j616 cb8121f
Updates based on review
j616 ced27ab
Add notes on terminology to AppNote0024
j616 bc48f7b
Fix linting
j616 c092bca
Add note regarding reference counting when deleting Objects
j616 77e1e7f
Add note on rejecting miss-use of init segments and media segments an…
j616 92b3566
Use `object_id` for init object on flow segments endpoint
j616 89e88a3
Add note to AppNote0024 on minimizing creation of new init segments.
j616 c09b54b
Specify that Object timerange MUST NOT be set for init segment objects
j616 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| { | ||
| "id": "4f79cfd1-c057-47f4-8e4d-1b126ca7bf34", | ||
| "source_id": "2aa143ac-0ab7-4d75-bc32-5c00c13d186f", | ||
| "generation": 0, | ||
| "created": "2008-05-27T18:51:00Z", | ||
| "metadata_updated": "2023-09-14T09:45:26Z", | ||
| "segments_updated": "2023-09-14T09:45:26Z", | ||
| "description": "Big Buck Bunny", | ||
| "label": "bbb", | ||
| "format": "urn:x-nmos:format:video", | ||
| "created_by": "tams-dev", | ||
| "updated_by": "tams-dev", | ||
| "tags": { | ||
| "input_quality": "contribution" | ||
| }, | ||
| "codec": "video/h264", | ||
| "container": "video/iso.segment", | ||
| "avg_bit_rate": 2479, | ||
| "segment_duration": { | ||
| "numerator": 10 | ||
| }, | ||
| "essence_parameters": { | ||
| "init_segments": true, | ||
| "frame_rate": { | ||
| "numerator": 24, | ||
| "denominator": 1 | ||
| }, | ||
| "frame_width": 1280, | ||
| "frame_height": 720, | ||
| "bit_depth": 8, | ||
| "interlace_mode": "progressive", | ||
| "colorspace": "BT709", | ||
| "transfer_characteristic": "SDR", | ||
| "aspect_ratio": { | ||
| "numerator": 16, | ||
| "denominator": 9 | ||
| }, | ||
| "pixel_aspect_ratio": { | ||
| "numerator": 1, | ||
| "denominator": 1 | ||
| }, | ||
| "component_type": "YCbCr", | ||
| "vert_chroma_subs": 2, | ||
| "horiz_chroma_subs": 2, | ||
| "avc_parameters": { | ||
| "profile": 100, | ||
| "level": 31, | ||
| "flags": 0 | ||
| } | ||
| }, | ||
| "collected_by": [ | ||
| "e85efab4-993b-4ad6-9af3-4cd8d0d38860" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| [ | ||
| { | ||
| "object_id": "846023d3-612d-5014-bc47-88f6eb2d04bb", | ||
| "timerange": "[0:0_10:0)", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/846023d3-612d-5014-bc47-88f6eb2d04bb" | ||
| } | ||
| ], | ||
| "init_object": { | ||
| "object_id": "9ef06e23-b882-4a93-b005-480de42ef4e9", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/9ef06e23-b882-4a93-b005-480de42ef4e9" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "object_id": "25be83fc-11d1-5743-9d47-6865cef5ea35", | ||
| "timerange": "[10:0_20:0)", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/25be83fc-11d1-5743-9d47-6865cef5ea35" | ||
| } | ||
| ], | ||
| "init_object": { | ||
| "object_id": "9ef06e23-b882-4a93-b005-480de42ef4e9", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/9ef06e23-b882-4a93-b005-480de42ef4e9" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "object_id": "8b785422-6a82-5d60-b25a-f77e0a748321", | ||
| "timerange": "[20:0_30:0)", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/8b785422-6a82-5d60-b25a-f77e0a748321" | ||
| } | ||
| ], | ||
| "init_object": { | ||
| "object_id": "192472f1-55fd-45dc-b355-e6833a3a140c", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/192472f1-55fd-45dc-b355-e6833a3a140c" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "id": "846023d3-612d-5014-bc47-88f6eb2d04bb", | ||
| "referenced_by_flows": [ | ||
| "4f79cfd1-c057-47f4-8e4d-1b126ca7bf34", | ||
| "0fde9c11-da9d-434a-a113-d3b20a2cf251" | ||
| ], | ||
| "first_referenced_by_flow": "4f79cfd1-c057-47f4-8e4d-1b126ca7bf34", | ||
| "timerange": "[150:0_200:0)", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/846023d3-612d-5014-bc47-88f6eb2d04bb" | ||
| } | ||
| ], | ||
| "init_object": { | ||
| "id": "9ef06e23-b882-4a93-b005-480de42ef4e9", | ||
| "get_urls": [ | ||
| { | ||
| "url": "https://store.example.com/tams-e2b89b02-21e7-5f9d-aa2d-db38b01453c9/9ef06e23-b882-4a93-b005-480de42ef4e9" | ||
| } | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "type": "object", | ||
| "description": "Provides the location and metadata of the media files corresponding to a Media Object.", | ||
| "title": "Object", | ||
| "allOf": [ | ||
| { | ||
| "properties": { | ||
| "key_frame_count": { | ||
| "description": "The number of key frames in the Media Object. This should be set greater than zero when the Media Object contains key frames that serve as a stream access point", | ||
| "type": "integer" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "$ref": "object-core.json" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on whether this should be a Flow property? Since it's kinda an artifact of how the
containerand splitting into objects works (and lines up with the Flow GET example in this PR, which seems neater IMO)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've partly placed this here due to how the Profiles proposal has been architected. I think it would need to be at this level to allow the profile to match on this property which has a significant role in compatibility of media.