Skip to content

Clarify ResourceManager's allow-one guarantee #30400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tamird wants to merge 1 commit into from
Closed

Clarify ResourceManager's allow-one guarantee #30400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/google/devtools/build/lib/actions/ResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@
* </ol>
*
* <p>The resource manager also allows a slight overallocation of the resources to account for the
* fact that requested resources are usually estimated using a pessimistic approximation. It also
* guarantees that at least one thread will always be able to acquire any amount of requested
* resources (even if it is greater than amount of available resources). Therefore, assuming that
* threads correctly release acquired resources, Blaze will never be fully blocked.
* fact that requested resources are usually estimated using a pessimistic approximation. When
* {@code --allow_one_action_on_resource_unavailable} is enabled, an unused resource type can be
* acquired even if the request exceeds its capacity. Worker quota and concurrency limits can still
* block acquisition.
*/
@ThreadSafe
public class ResourceManager implements ResourceEstimator {
Expand Down
Loading