Skip to content

Use primitive resource availability operands - #30399

Closed
tamird wants to merge 2 commits into
bazelbuild:masterfrom
tamird:tamird/fix-resource-availability-primitives
Closed

tamird wants to merge 2 commits into
bazelbuild:masterfrom
tamird:tamird/fix-resource-availability-primitives

Conversation

@tamird

@tamird tamird commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

All resource availability calls use doubles except local-test counts,
whose int values widen exactly. Accept primitive doubles directly and
remove the redundant conversions without changing scheduling behavior.

@github-actions github-actions Bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Jul 21, 2026
@tamird

tamird commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Extracted from #30310. Resource availability already uses doubles
except for local-test counts, whose integer values widen exactly; this
removes the redundant Number conversions ahead of the scheduling work.

@meisterT
meisterT requested a review from bigelephant29 July 22, 2026 10:38
@bigelephant29 bigelephant29 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 27, 2026
@tamird
tamird force-pushed the tamird/fix-resource-availability-primitives branch from 44ea546 to a592339 Compare July 29, 2026 11:07
All resource availability calls use doubles except local-test counts,
whose int values widen exactly. Accept primitive doubles directly and
remove the redundant conversions without changing scheduling behavior.
@tamird
tamird force-pushed the tamird/fix-resource-availability-primitives branch from a592339 to b3d5b39 Compare July 29, 2026 11:22
@tamird

tamird commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@bigelephant29 This is approved and all presubmit checks pass. Is anything else needed to land it?

[tamirdex]

@tamird

tamird commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

@bigelephant29 I rebased this after you applied the awaiting-PR-merge label, is there anything that needs to be done?

@copybara-service copybara-service Bot closed this in 0ee3e3f Aug 5, 2026
@github-actions github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 5, 2026
@tamird
tamird deleted the tamird/fix-resource-availability-primitives branch August 5, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Performance Issues for Performance teams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants