絞り込み検索でクリアを実行しても、検索条件が戻らないため修正 - #4490
Merged
Merged
Conversation
Collaborator
|
@IwasakiRyuichi ありがとうございます、マージしますね |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ryuring
こちらご確認お願いします。
原因
検索条件はセッションに保持され、次回リクエストと array_merge されます。この仕組みでは、キー自体が送信されないと古い値が上書きされず残ります。
「アクセスルールグループ（タイプ）」のラジオに 'hiddenField' => false が指定されており、未選択のまま検索すると permission_group_type キーが送信されず、セッションの古い絞り込み条件が残ってクリアが効きませんでした。
修正内容
'hiddenField' => false を削除し、未選択時も空文字が送信されるようにしました。
issue
#4452