Skip to content

Publish releases from the release environment - #119

Open
jeremy wants to merge 1 commit into
mainfrom
release-hardening-v2
Open

jeremy wants to merge 1 commit into
mainfrom
release-hardening-v2

Conversation

@jeremy

@jeremy jeremy commented Oct 8, 2026

Copy link
Copy Markdown
Member

The release job now runs in the release environment, so a v* tag waits for a reviewer before the binaries are built and published.

Why: the release job publishes the GitHub Release and its binaries. Until now any v* tag push published straight away. The release environment already exists, admits only v* tags, and requires a reviewer.

Releasing now: push the v* tag as before. The run waits at the release job until someone approves it under "Review deployments" on the run page.

Who approves: kevinmcconnell or a member of sip. Self-review is allowed, so the person who pushed the tag can approve it.

If #117 lands first, close this PR instead: #117 moves releases to a dispatch on main, and the release environment will admit main for it.

Nothing else needs configuring when this merges. Merging is the owners' call.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 01:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T01:36:04.426748Z 79bf56e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants