Adopt SDK v0.24.0 and make the plugin rename failure-safe

[robzolkos]

Summary

• replace the unpublished SDK pseudo-version with tagged v0.24.0
• refresh SDK and MCP provenance plus the Nix vendor hash
• install basecamp-cli@37signals at each Claude scope before removing the working basecamp@37signals copy
• leave the old scoped copy installed when replacement installation fails

Verification

• GOWORK=off bin/ci
• local binary build metadata resolves github.com/basecamp/basecamp-sdk/go v0.24.0
• read-only live-account smoke tests: auth validation, accounts, current user, projects, people, assignments, recordings, notifications, search, and doctor
• connector doctor attempted separately; release remains gated on reconnecting the currently refused agent credential

---

Summary by cubic

Adopts the released SDK v0.24.0 and makes the Claude plugin rename failure-safe.

• Replaces the unpublished SDK pseudo-version with v0.24.0 and refreshes SDK and MCP provenance plus the Nix vendor hash.
• Installs basecamp-cli@37signals at each Claude scope before removing the working basecamp@37signals copy, leaving the old copy in place when the replacement installation fails.

^{Written for commit ca17ae8. Summary will update on new commits.}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[cubic-dev-ai]

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/commands/wizard_agents_test.go">

<violation number="1" location="internal/commands/wizard_agents_test.go:86">
P3: `stubClaudeMigration(t, "")` does not mean "no scope fails": `[ "$5" = "" ]` is true whenever the fifth positional is empty or absent, so any `plugin install` invocation with fewer than five args is forced to exit 1. Today `preinstallRenamedClaudePlugin` always installs with `--scope`, so this is latent, but the condition contradicts the helper's no-failure contract and will silently fail a future unscoped install. Guard the scope comparison with a non-empty check.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic</sub>

[cubic-dev-ai]

P3: stubClaudeMigration(t, "") does not mean "no scope fails": [ "$5" = "" ] is true whenever the fifth positional is empty or absent, so any plugin install invocation with fewer than five args is forced to exit 1. Today preinstallRenamedClaudePlugin always installs with --scope, so this is latent, but the condition contradicts the helper's no-failure contract and will silently fail a future unscoped install. Guard the scope comparison with a non-empty check.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At internal/commands/wizard_agents_test.go, line 86:

<comment>`stubClaudeMigration(t, "")` does not mean "no scope fails": `[ "$5" = "" ]` is true whenever the fifth positional is empty or absent, so any `plugin install` invocation with fewer than five args is forced to exit 1. Today `preinstallRenamedClaudePlugin` always installs with `--scope`, so this is latent, but the condition contradicts the helper's no-failure contract and will silently fail a future unscoped install. Guard the scope comparison with a non-empty check.</comment>

<file context>
@@ -77,6 +77,54 @@ func readClaudeCalls(t *testing.T, claudePath string) string {
+	logFile := filepath.Join(dir, "calls.log")
+	script := "#!/bin/sh\n" +
+		"echo \"$*\" >> \"" + logFile + "\"\n" +
+		"if [ \"$1 $2\" = \"plugin install\" ] && [ \"$5\" = \"" + failedInstallScope + "\" ]; then exit 1; fi\n" +
+		"exit 0\n"
+	path := filepath.Join(dir, "claude")
</file context>