Hold the request line's keys to a contract, and the skill to the line by jeremy · Pull Request #848 · basecamp/basecamp-cli

jeremy · 2026-10-06T05:27:24Z

Stacked on #843 (base connect-role), because the contract includes #843's role key. It retargets to main once #843 merges.

Why

basecamp connect supersedes the local agent connector, so its "type":"request" line is the contract that the basecamp-connect skill, and any session or practice driving the connector, keys on. Until now nothing held it:

A renamed tag passed every test. The handoff tests decode the line into the same struct that wrote it.
The skill's example could drift silently. The example in skills/basecamp-connect/SKILL.md that teaches the reader the field names could drift from the real line with nothing noticing.

This is the small part worth keeping from "one format for both connectors". We don't need a shared driver. We do need a written contract for the connector that stays.

What changes

requestLineContract names every key the line must carry, with nested keys written as parent.child. A renamed or dropped key fails TestTheRequestLineKeepsItsContract. Adding a key is allowed.
TestTheSkillDocumentsTheRequestLineItGets holds the skill's example to the line's keys exactly. A key added to the line has to be documented where readers learn it.
HandoffLine's doc comment says so.

Tests

These tests pin current behaviour, so they pass on creation. I checked they catch drift by mutating:

renaming requester_id's tag fails the contract test;
removing role from the skill example fails the skill test;
adding an undocumented field to the line fails the skill test.

make check passes on linux.

Summary by cubic

Pins the keys of the "type":"request" handoff line to a contract, and holds the basecamp-connect skill's example to those exact keys. The contract covers every key the line can carry: optional fields are flushed by reflection so a key hidden behind omitempty can't slip past, nested keys are compared as full dotted paths, and a zero-valued line keeps every required key. The line's keys must equal the contract in both directions, so renaming, dropping, or adding a key fails tests, and the skill has to document any change, where before a renamed tag passed tests and the skill's example could drift silently.

^{Written for commit b5b21a9. Summary will update on new commits.}

jeremy · 2026-10-06T05:27:33Z

@codex review

chatgpt-codex-connector · 2026-10-06T05:27:38Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-07T04:17:40.147319Z	`b5b21a9`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d697b4a57d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jeremy · 2026-10-06T05:44:03Z

@codex review

jeremy · 2026-10-06T05:44:04Z

@cubic-dev-ai review

cubic-dev-ai · 2026-10-06T05:44:08Z

@cubic-dev-ai review

@jeremy I have started the AI code review. It will take a few minutes to complete.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

cubic-dev-ai

No issues found across 2 files

_{Re-trigger cubic}

chatgpt-codex-connector · 2026-10-06T05:45:37Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 451dec7599

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jeremy · 2026-10-06T06:38:12Z

Review state at head `afe9f62`

Base: rebased onto Tell operators from participants on every connect request #843 at dcb99fa, still connect-role. Retarget to main once Tell operators from participants on every connect request #843 merges.
CI: green. make check passes on linux.
Codex and cubic: no findings on d6bdf05.
Copilot: not reviewed. It answered that the requester's quota is exhausted.
Unresolved threads: 0.
Merge state: mergeable. Not merged.

Fixed after review:

The line's keys must equal the contract, both ways.
A zero-valued line must keep every key except the two optional ones (recording.project_name, requester_name), so a required key that gains omitempty fails.
The fixture is filled by reflection, and keys are walked at any depth.

I checked each by mutation: renaming a tag, an undocumented key, and omitempty on acknowledge each fail.

Later fixes: the skill example is found under CRLF line endings, and an empty object counts as a key. Both were raised by Codex and cubic, with a test that fails without them.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e09a4e88c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jeremy · 2026-10-06T19:54:47Z

@codex review

jeremy · 2026-10-06T19:54:48Z

@cubic-dev-ai review

cubic-dev-ai · 2026-10-06T19:54:52Z

@cubic-dev-ai review

@jeremy I have started the AI code review. It will take a few minutes to complete.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e09a4e88c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cubic-dev-ai

No issues found across 2 files

_{Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai

No issues found across 2 files

_{Turn on auto-fix | Re-trigger cubic}

chatgpt-codex-connector · 2026-10-06T21:09:45Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: afe9f62cff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a440615d68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jeremy · 2026-10-06T23:42:48Z

@codex review

jeremy · 2026-10-06T23:42:49Z

@cubic-dev-ai review

cubic-dev-ai · 2026-10-06T23:42:54Z

@cubic-dev-ai review

@jeremy I have started the AI code review. It will take a few minutes to complete.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

cubic-dev-ai

No issues found across 2 files

_{Turn on auto-fix | Re-trigger cubic}

chatgpt-codex-connector · 2026-10-06T23:45:00Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: a440615d68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The request line is read by programs nothing in this repo runs: the basecamp-connect skill, and the session or practice driving the connector. Its keys are what those readers match on. A renamed json tag passed every test, because the tests decode the line into the same struct that wrote it, and the skill's example of the line could drift from the real one with nothing noticing. Pin the names the line must carry, and hold the skill's example to the line's keys exactly, so a renamed or dropped key fails here, and a key added to the line has to be documented where the reader learns it.

The fixture set only the two optional fields that exist today, so a key added later with omitempty stayed out of the comparison, and keys were read one level deep. Fill every field by reflection, and walk nested objects to their full dotted path.

…o values A key added to the line had to reach the skill but not the contract, and a required key that gained omitempty vanished from real lines at its zero value while the filled fixture still showed it. The line's keys now equal the contract's, and a zero-valued line keeps every key but the two documented as optional.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

jeremy · 2026-10-07T04:15:50Z

@codex review

jeremy · 2026-10-07T04:15:51Z

@cubic-dev-ai review

cubic-dev-ai · 2026-10-07T04:15:56Z

@cubic-dev-ai review

@jeremy I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

_{Turn on auto-fix | Re-trigger cubic}

chatgpt-codex-connector · 2026-10-07T04:17:38Z

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: b5b21a9e3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jeremy · 2026-10-07T05:27:53Z

Rebased onto main (943dbb5). connect-role had landed as #843, so only this PR's own four commits were replayed, with git rebase --onto origin/main 164bb786. Nothing conflicted. #840 renamed the plugin, but the skill this test reads, skills/basecamp-connect/SKILL.md, kept its path, and its example still matches the request line's keys after #843 and #847. The fmt, vet, lint, test and tidy gates passed on linux before the push, and CI is green on b5b21a9.

Review threads: 0 open (all 10 were already resolved). Codex reported on b5b21a9 with no major issues, and cubic found no issues. Copilot can't review because the requester's quota is exhausted.

jeremy requested a review from a team as a code owner October 6, 2026 05:27

Copilot AI balanced review requested due to automatic review settings October 6, 2026 05:27

github-actions Bot added the tests Tests (unit and e2e) label Oct 6, 2026

Copilot started reviewing on behalf of jeremy October 6, 2026 05:27 View session

Copilot AI reviewed Oct 6, 2026

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread internal/connector/handoff.go

Comment thread internal/connector/request_contract_test.go Outdated

chatgpt-codex-connector Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread internal/connector/request_contract_test.go Outdated

jeremy requested a balanced review from Copilot October 6, 2026 05:44

Copilot started reviewing on behalf of jeremy October 6, 2026 05:44 View session

Copilot AI reviewed Oct 6, 2026

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

jeremy mentioned this pull request Oct 6, 2026

Tell operators from participants on every connect request #843

Merged

jeremy force-pushed the connect-request-contract branch from 451dec7 to e09a4e8 Compare October 6, 2026 19:49

chatgpt-codex-connector Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread internal/connector/request_contract_test.go

jeremy requested a balanced review from Copilot October 6, 2026 19:54

Copilot started reviewing on behalf of jeremy October 6, 2026 19:55 View session

Copilot AI reviewed Oct 6, 2026

chatgpt-codex-connector Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread internal/connector/request_contract_test.go Outdated

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

jeremy force-pushed the connect-request-contract branch from e09a4e8 to d6bdf05 Compare October 6, 2026 20:08

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

jeremy force-pushed the connect-request-contract branch from afe9f62 to a440615 Compare October 6, 2026 23:38

chatgpt-codex-connector Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread internal/connector/request_contract_test.go

Comment thread internal/connector/request_contract_test.go

jeremy requested a balanced review from Copilot October 6, 2026 23:42

Copilot started reviewing on behalf of jeremy October 6, 2026 23:43 View session

Copilot AI reviewed Oct 6, 2026

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

Base automatically changed from connect-role to main October 7, 2026 03:48

jeremy added 4 commits October 6, 2026 20:52

Find the skill's example under CRLF, and count an empty object as a key

b5b21a9

Copilot AI balanced review requested due to automatic review settings October 7, 2026 04:05

jeremy force-pushed the connect-request-contract branch from a440615 to b5b21a9 Compare October 7, 2026 04:05

Copilot started reviewing on behalf of jeremy October 7, 2026 04:05 View session

Copilot AI reviewed Oct 7, 2026

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

jeremy mentioned this pull request Oct 7, 2026

Read the agent connection ceremony as data with --json #852

Open

jeremy merged commit 9454de9 into main Oct 7, 2026
30 of 31 checks passed

jeremy deleted the connect-request-contract branch October 7, 2026 06:24

Conversation

jeremy commented Oct 6, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changes

Tests

Summary by cubic

Uh oh!

jeremy commented Oct 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jeremy commented Oct 6, 2026

Uh oh!

jeremy commented Oct 6, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 6, 2026

Uh oh!

jeremy commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review state at head afe9f62

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jeremy commented Oct 6, 2026

Uh oh!

jeremy commented Oct 6, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jeremy commented Oct 6, 2026

jeremy commented Oct 6, 2026 •

edited by cubic-dev-ai Bot

Loading

chatgpt-codex-connector Bot commented Oct 6, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

jeremy commented Oct 6, 2026 •

edited

Loading

Review state at head `afe9f62`