fix: move unit-test-instructions from build-and-test to code-generation#403
Open
jeromevdl wants to merge 2 commits into
Open
fix: move unit-test-instructions from build-and-test to code-generation#403jeromevdl wants to merge 2 commits into
jeromevdl wants to merge 2 commits into
Conversation
build-and-test was generating unit-test-instructions.md describing tests to write, but code-generation already includes unit test files in its plan and generates them during execution. This caused redundant duplication. Move unit-test-instructions production to code-generation (Step 4, before subagent delegation) so it guides test generation. build-and-test now consumes it for execution and focuses on integration/performance/security test instructions only. Fixes awslabs#397
jeromevdl
requested review from
a team,
Kalindi-Dev,
harmjeff,
leandrodamascena,
raj-jain-aws,
scottschreckengaust and
spraja08
github-actions
Bot
added
documentation
…sumption Step 2 now lists unit-test-instructions before code-summary (logical order: what tests to run, then what was built). Step 10 references all units' instructions via the glob path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #397
The
build-and-teststage was generatingunit-test-instructions.md(describing unit tests to write), butcode-generationalready includes unit test files in its plan and generates them during execution. This caused redundant duplication.Changes
code-generation: Addedunit-test-instructionstoproduces:. Added Step 4 (Generate Unit Test Instructions) between plan approval and code generation, so the instructions guide the subagent. Included in the delegation prompt context.build-and-test: Removedunit-test-instructionsfromproduces:, added it toconsumes:. Steps 4-8 now generate only integration/performance/security test instructions. Step 10 references the consumed artifact for execution.docs/reference/04-stages/construction.mdanddocs/reference/16-artifact-vocabulary.mdto reflect the moved artifact.bun scripts/package.ts --checkpasses).tests/fixtures/designer-export/export.json(artifact count unchanged at 122).Test Results
All relevant tests pass (smoke, unit, integration graph/stage-consistency tests). Two pre-existing failures unrelated to this change (README badge version mismatch in t68, agents count in t66).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.