fix: respect conversation language in generated files#290
Conversation
|
@raj-jain-aws This is the v2 equivalent of #177. Same approach — language instruction in shared convention/protocol files so future skills are automatically covered. Without this fix, non-English users often end up sending extra prompts like "please rewrite that in Japanese" just to get the generated files in their language — an unnecessary round-trip that breaks the autonomous flow. Would appreciate your review when you have a chance. |
f57bd58 to
5027942
Compare
Add language rules to ensure user-facing files (questions, plans, and design artifacts) are written in the human's conversation language. - aidlc-question-format.md: added Language section - aidlc-builder-protocol.md: added Rule 7 (Language) to cover plans and design artifacts - Rebuilt dist/
5027942 to
1267219
Compare
|
@raj-jain-aws Gentle ping — would appreciate a review when you get a chance. This is the v2 equivalent of #177 which you previously approved. Thanks! |
|
Hi @masamaru0513 - Sorry for the delay in response. The |
|
Hi @raj-jain-aws — thanks for the heads-up! I'll wait for the refactoring to settle and then address this fix accordingly. Thanks! |
Summary
Skill-generated files (questions, plans, and design artifacts) were output in English regardless of the user's conversation language. Closes #288
Changes
Languagesection toaidlc-common/conventions/aidlc-question-format.mddirecting question files to match the human's conversation language.aidlc-common/protocols/aidlc-builder-protocol.mdSection 3, extending the language rule to plans and design artifacts. User-facing files are explicitly defined as: question files, plan files, and design artifacts. All other files remain in English.Note:
*-validation-result.mdis intentionally excluded becauseaidlc-process-checker.jsparses its---PROCESS-CHECK-DATA---block programmatically.Approach
Same approach as the v1 fix (#177): place the language instruction in shared convention/protocol files so all current and future skills automatically inherit the rule without per-skill modification. In v2, the relevant shared files are
aidlc-question-format.md(for questions) andaidlc-builder-protocol.md(for plans and design artifacts).Note on dist/
An earlier contributor's commit (
be2b776 feat: adding v2 branch) updatedsrc/but did not include the correspondingdist/rebuild. When I ranmake build-kirofor this PR, those unrelated changes appeared indist/as well. I have excluded them from this PR and only included thedist/files corresponding to my own changes. Filed #289 (RFC) to discuss the dist build policy for contributors going forward.User experience
Before: Question files (e.g.,
wireframes-questions.md) and design artifacts were generated in English even when the conversation was conducted in Japanese.After: User-facing generated files are written in the user's conversation language.
Checklist
Test Plan
/aidlc-orchestrator 簡単なTODOアプリを作りたい*-questions.mdfiles are generated in JapaneseAcknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.