Skip to content

fix: respect conversation language in generated files#290

Closed
masamaru0513 wants to merge 1 commit into
awslabs:v2from
masamaru0513:fix/288-respect-conversation-language
Closed

fix: respect conversation language in generated files#290
masamaru0513 wants to merge 1 commit into
awslabs:v2from
masamaru0513:fix/288-respect-conversation-language

Conversation

@masamaru0513

@masamaru0513 masamaru0513 commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Skill-generated files (questions, plans, and design artifacts) were output in English regardless of the user's conversation language. Closes #288

Changes

  • Added a Language section to aidlc-common/conventions/aidlc-question-format.md directing question files to match the human's conversation language.
  • Added Rule 7 (Language) to aidlc-common/protocols/aidlc-builder-protocol.md Section 3, extending the language rule to plans and design artifacts. User-facing files are explicitly defined as: question files, plan files, and design artifacts. All other files remain in English.

Note: *-validation-result.md is intentionally excluded because aidlc-process-checker.js parses its ---PROCESS-CHECK-DATA--- block programmatically.

Approach

Same approach as the v1 fix (#177): place the language instruction in shared convention/protocol files so all current and future skills automatically inherit the rule without per-skill modification. In v2, the relevant shared files are aidlc-question-format.md (for questions) and aidlc-builder-protocol.md (for plans and design artifacts).

Note on dist/

An earlier contributor's commit (be2b776 feat: adding v2 branch) updated src/ but did not include the corresponding dist/ rebuild. When I ran make build-kiro for this PR, those unrelated changes appeared in dist/ as well. I have excluded them from this PR and only included the dist/ files corresponding to my own changes. Filed #289 (RFC) to discuss the dist build policy for contributors going forward.

User experience

Before: Question files (e.g., wireframes-questions.md) and design artifacts were generated in English even when the conversation was conducted in Japanese.

After: User-facing generated files are written in the user's conversation language.

Checklist

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Test Plan

  1. Start AI-DLC v2 with /aidlc-orchestrator 簡単なTODOアプリを作りたい
  2. Proceed through inception skills (requirements-analysis, user-stories, wireframes)
  3. Verify *-questions.md files are generated in Japanese

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@masamaru0513 masamaru0513 requested review from a team as code owners May 20, 2026 05:13
@github-actions github-actions Bot added documentation Improvements or additions to documentation github rules labels May 20, 2026
@masamaru0513 masamaru0513 changed the base branch from main to v2 May 20, 2026 05:14
@masamaru0513

masamaru0513 commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

@raj-jain-aws This is the v2 equivalent of #177. Same approach — language instruction in shared convention/protocol files so future skills are automatically covered.

Without this fix, non-English users often end up sending extra prompts like "please rewrite that in Japanese" just to get the generated files in their language — an unnecessary round-trip that breaks the autonomous flow.

Would appreciate your review when you have a chance.

@masamaru0513 masamaru0513 changed the base branch from v2 to main May 21, 2026 16:02
@masamaru0513 masamaru0513 changed the base branch from main to v2 May 21, 2026 16:03
@masamaru0513 masamaru0513 force-pushed the fix/288-respect-conversation-language branch from f57bd58 to 5027942 Compare May 28, 2026 22:49
Add language rules to ensure user-facing files (questions, plans, and
design artifacts) are written in the human's conversation language.

- aidlc-question-format.md: added Language section
- aidlc-builder-protocol.md: added Rule 7 (Language) to cover plans
  and design artifacts
- Rebuilt dist/
@masamaru0513 masamaru0513 force-pushed the fix/288-respect-conversation-language branch from 5027942 to 1267219 Compare May 28, 2026 23:05
@masamaru0513

Copy link
Copy Markdown
Contributor Author

@raj-jain-aws Gentle ping — would appreciate a review when you get a chance. This is the v2 equivalent of #177 which you previously approved. Thanks!

@raj-jain-aws

Copy link
Copy Markdown
Contributor

Hi @masamaru0513 - Sorry for the delay in response. The v2 branch is going through a bit of refactoring right now from the feedback received so far. If you could you wait about a week, let the core structure settle, and then bring this PR on top of that, that'd be great. Thanks!

@masamaru0513

Copy link
Copy Markdown
Contributor Author

Hi @raj-jain-aws — thanks for the heads-up! I'll wait for the refactoring to settle and then address this fix accordingly. Thanks!

@masamaru0513

Copy link
Copy Markdown
Contributor Author

Closing in favor of #353, which rebuilds this fix on top of the current v2 structure (shared rules moved into conventions/ + aidlc-work-method). #353 also avoids the dist/ artifact issue noted here, since kiro/dist/ is gitignored in v2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Skill clarification questions output in English regardless of conversation language (v2)

2 participants