Upgrade to go 1.16 and add darwin-arm64 support.#42
Upgrade to go 1.16 and add darwin-arm64 support.#42DennoVonDiesel wants to merge 7 commits intoaws:mainlinefrom
Conversation
Build darwin-arm64 binaries
Update to go 1.16 to support arm64
Fix copy pasta
|
nice |
|
@DennoVonDiesel when I try to use the install file as: I'm missing some steps? |
|
@williantenfen I don't see that the system command install has a -i option on either darwin or linux. I think the correct way is to unzip the bundle file that gets created after building the package and run that installer. |
|
thanks! got it. working fine! |
|
This is great hopefully @Yangtao-Hua or @yuting-fan can look at merging soon. |
|
It would be really nice to get session-manager-plugin working for M1 machines without having to use a fork of this library! |
|
Thank you for the changes, we noticed it is highly required feature, it is in our plan. |
|
Do you have an ETA @Yangtao-Hua ? |
|
@Yangtao-Hua This is flagged as a highly required feature but no movement in over 3 months. Should any community work towards this repository move away from AWS and be managed by the community due to the lack of engagement? |
| // either express or implied. See the License for the specific language governing | ||
| // permissions and limitations under the License. | ||
|
|
||
| //go:build darwin || freebsd || linux || netbsd || openbsd |
There was a problem hiding this comment.
I think go:build isn't added until 1.17.
Any reason not to upgrade to latest go version (which also removes the +build lines)?
|
We are actively working to add darwin-arm64 support and this change is currently under review. Will keep this thread updated on the release as we make progress. |
|
Any update @nitikaaws ? |
|
Nice definition of "actively" @nitikaaws |
|
Apologies for the delay in releasing the support for darwin-arm64! Our team is looking into this and will provide an update when we are closer to the release. |
|
@nitikaaws Any chance of a community release? You said you were reviewing this change in November. |
go 1.16 is required for darwin-arm64 support. I've added this to the build process.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.