Skip to content

fix: Replace plain SHA-256 with HMAC-SHA256 for remote function artifact integrity #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mollyheamazon wants to merge 11 commits into
base: master
Choose a base branch
from
+826 −94
Open

fix: Replace plain SHA-256 with HMAC-SHA256 for remote function artifact integrity #5602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d469f05
Draft fix with unit tests
mollyheamazon Mar 5, 2026
72a3982
Update after testing
mollyheamazon Mar 7, 2026
08c6146
Merge branch 'master' into hmac-key-new
mollyheamazon Mar 7, 2026
90f1f66
Add wheel install for remote function integ test to use local code
mollyheamazon Mar 9, 2026
0045281
Update confest for whell build
mollyheamazon Mar 9, 2026
9a43409
fix build setup error
mollyheamazon Mar 10, 2026
b4351fd
Update license format
mollyheamazon Mar 10, 2026
65ff9db
Add upper bound to setuptools for sagemaker-core
mollyheamazon Mar 10, 2026
35adf56
Try to resolve setuptools version conflict
mollyheamazon Mar 10, 2026
1bbcecb
Further fix on confest
mollyheamazon Mar 10, 2026
820ec32
Remove legacy fallback, add length check to secrete_arn, remove greed…
mollyheamazon Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sagemaker-core/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools>=64"]
requires = ["setuptools>=64,<77"]
build-backend = "setuptools.build_meta"

[project]
Expand Down Expand Up @@ -40,10 +40,10 @@ dependencies = [
"tblib>=1.7.0",
]
requires-python = ">=3.9"
license = {text = "Apache-2.0"}
classifiers = [
"Development Status :: 3 - Alpha",
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
6 changes: 0 additions & 6 deletions sagemaker-core/src/sagemaker/core/remote_function/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,6 @@ def wrapper(*args, **kwargs):
s3_uri=s3_path_join(
job_settings.s3_root_uri, job.job_name, EXCEPTION_FOLDER
),

)
except ServiceError as serr:
chained_e = serr.__cause__
Expand Down Expand Up @@ -406,7 +405,6 @@ def wrapper(*args, **kwargs):
return serialization.deserialize_obj_from_s3(
sagemaker_session=job_settings.sagemaker_session,
s3_uri=s3_path_join(job_settings.s3_root_uri, job.job_name, RESULTS_FOLDER),

)

if job.describe()["TrainingJobStatus"] == "Stopped":
Expand Down Expand Up @@ -1008,7 +1006,6 @@ def from_describe_response(describe_training_job_response, sagemaker_session):
job_return = serialization.deserialize_obj_from_s3(
sagemaker_session=sagemaker_session,
s3_uri=s3_path_join(job.s3_uri, RESULTS_FOLDER),

)
except DeserializationError as e:
client_exception = e
Expand All @@ -1020,7 +1017,6 @@ def from_describe_response(describe_training_job_response, sagemaker_session):
job_exception = serialization.deserialize_exception_from_s3(
sagemaker_session=sagemaker_session,
s3_uri=s3_path_join(job.s3_uri, EXCEPTION_FOLDER),

)
except ServiceError as serr:
chained_e = serr.__cause__
Expand Down Expand Up @@ -1110,7 +1106,6 @@ def result(self, timeout: float = None) -> Any:
self._return = serialization.deserialize_obj_from_s3(
sagemaker_session=self._job.sagemaker_session,
s3_uri=s3_path_join(self._job.s3_uri, RESULTS_FOLDER),

)
self._state = _FINISHED
return self._return
Expand All @@ -1119,7 +1114,6 @@ def result(self, timeout: float = None) -> Any:
self._exception = serialization.deserialize_exception_from_s3(
sagemaker_session=self._job.sagemaker_session,
s3_uri=s3_path_join(self._job.s3_uri, EXCEPTION_FOLDER),

)
except ServiceError as serr:
chained_e = serr.__cause__
Expand Down
Loading
Loading